feat(icon): sharper wisp launcher glyph + visible splash Cancel pill#625
Open
dmnyc wants to merge 2 commits into
Open
feat(icon): sharper wisp launcher glyph + visible splash Cancel pill#625dmnyc wants to merge 2 commits into
dmnyc wants to merge 2 commits into
Conversation
The debug APK shipped the default Android Studio launcher icon (green grid). Replace it with the branded wisp glyph — an orange mark on a solid black surround, matching the iOS app icon. - ic_launcher_foreground.xml: pure vector ported from the iOS source (1024-unit viewport, evenodd so the eye cutouts show the black bg). - ic_launcher_background.xml: solid black surround. - Rendered PNGs (ic_launcher / ic_launcher_round) for every density, replacing the template .webp files; drops the now-unused foreground webps. - Splash screen's animated icon repoints at the new vector drawable.
The Cancel button shown during the add-account flow sat at BottomCenter with bottom padding, where the logo/wordmark/action-buttons column is drawn on top of it — making it effectively unreachable. Move it to a translucent pill pinned to the top-start corner (status-bar padded) and bump the pill opacity so it reads as a tappable affordance.
dmnyc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The debug APK currently ships an older, lower-resolution wisp icon. This replaces it with a sharper version — the orange mark on a solid black surround, matching the iOS app icon.
ic_launcher_foreground.xml— pure vector ported from the iOS source (1024-unit viewport, evenodd fill so the eye cutouts show the black background through).ic_launcher_background.xml— solid black surround.ic_launcher/ic_launcher_round) for every density, replacing the older lower-resolution.webpfiles; drops the now-unused foreground webps.windowSplashScreenAnimatedIconrepoints at the new vector drawable.BottomCenter(where the logo/wordmark/action-buttons column painted over it, making it effectively unreachable) to a translucent pill pinned to the top-start corner.Context
Carves the icon work out of #558, which mixed it with light-mode color changes that now conflict with the theme overhaul that's since landed. #558 is closed; the light-mode portion will be re-evaluated separately. The icon work itself is asset-only; the only code change is the small
SplashScreen.ktCancel-button move, folded in because it touches the same welcome screen.Testing
Built and installed on device; launcher icon and splash screen now show the wisp glyph, and the add-account Cancel pill is visible in the top-left corner.