feat(lnurl): render bech32 LNURLs in note content as payable cards#414
Open
dmnyc wants to merge 1 commit into
Open
feat(lnurl): render bech32 LNURLs in note content as payable cards#414dmnyc wants to merge 1 commit into
dmnyc wants to merge 1 commit into
Conversation
Detects a bare lnurl1... token in note content and renders it as a tappable payment card (matching the lightning-invoice / lightning- address card styles) instead of leaving it as plain text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lnurl1…bech32-encoded token in note content and renders it as a tappable payment card instead of leaving it as plain textWalletStore.detectInputTypeandLnurlResolver.resolvealready handlelnurl1…strings via the existing LNURL-pay flow, so Pay routes straight into the normal send sheetnevent1qqs9pdpv0j4wsnzrrser4h8ahejw38vxj3qtxnvzj6avsm9erpyxc6spp4mhxue69uhkummn9ekx7mqpz4mhxue69uhkummnw3ex2mrfw3jhxtn0wfnsygzfc9y74uer5h87484azmk62pt4fpy9za04mhpq47djurf5f9x0ys809v2e— a note whose content contains a bareLNURL1…stringScreenshots
Test plan
mainlnurl1…string and confirm it renders as a payable cardlnurl1…string is copied to the clipboard