fix(content): parse hashtags containing non-ASCII Unicode letters#398
Open
dmnyc wants to merge 1 commit into
Open
fix(content): parse hashtags containing non-ASCII Unicode letters#398dmnyc wants to merge 1 commit into
dmnyc wants to merge 1 commit into
Conversation
combinedRegex's hashtag pattern matched an ASCII-only character class
([a-zA-Z0-9_-]), so tags with umlauts, accents, or non-Latin letters
(e.g. #Kreuzworträtsel, #Weltbürger) stopped matching at the first
non-ASCII codepoint — the rest of the tag rendered as plain, untappable
text. Switch to \p{L} (Unicode letter property) so hashtags with any
script parse as a single token, matching the composer's existing
ComposerTextStyling.hashtagRegex which already used \p{L}\p{N}.
Fixes #396
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combinedRegex's hashtag pattern matched an ASCII-only character class ([a-zA-Z0-9_-]), so tags with umlauts, accents, or non-Latin letters stopped matching at the first non-ASCII codepoint — the rest of the tag rendered as plain, untappable text\p{L}(Unicode letter property) so hashtags with any script parse as a single token, matching the composer's existingComposerTextStyling.hashtagRegexwhich already used\p{L}\p{N}Reproduction
#Kreuzworträtsel→ was#Kreuzwortr(tappable) +ätsel(plain text); now the full tag is tappable. Same fix applies to#Weltbürger,#MuskelbasierteMobilität, and any hashtag with non-ASCII letters (CJK included).Fixes #396
Test plan