Skip to content

Successfully fixixng the errors and completing the functions in Linke… - #116

Open
24f3003274-RISHABH wants to merge 4 commits into
baranwalayush:mainfrom
24f3003274-RISHABH:main
Open

Successfully fixixng the errors and completing the functions in Linke…#116
24f3003274-RISHABH wants to merge 4 commits into
baranwalayush:mainfrom
24f3003274-RISHABH:main

Conversation

@24f3003274-RISHABH

Copy link
Copy Markdown

#33 completed

@24f3003274-RISHABH

Copy link
Copy Markdown
Author

#32 #33 Both

@24f3003274-RISHABH

Copy link
Copy Markdown
Author

#37 Done

@baranwalayush baranwalayush left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @24f3003274-RISHABH!
The implementations are correct, but there are few issues that you need to resolve before we can merge this.

  1. You should not push the executable files in a project, and they usually don't serve any purpose for the other users/contributors. So, you can either add a .gitignore file with .exe under it or simply remove these files.
  2. Same goes for the .png files. No need to push those.
  3. You should also remove the main function that you have written in the implementations. If you want to verify the changes, you can do that locally in a separate file.
  4. There also merge conflicts with this PR, you will need to resolve that too.

Let me know, if you need help with anything.

@24f3003274-RISHABH

Copy link
Copy Markdown
Author

I’ll make sure to avoid these in the future by using .gitignore, keeping test code separate, and resolving conflicts before pushing.
Thankyou for your guidance !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants