Successfully fixixng the errors and completing the functions in Linke… - #116
Open
24f3003274-RISHABH wants to merge 4 commits into
Open
Successfully fixixng the errors and completing the functions in Linke…#11624f3003274-RISHABH wants to merge 4 commits into
24f3003274-RISHABH wants to merge 4 commits into
Conversation
added 2 commits
February 28, 2026 23:46
Author
Author
|
#37 Done |
baranwalayush
requested changes
Mar 23, 2026
baranwalayush
left a comment
Owner
There was a problem hiding this comment.
Thank you for the PR @24f3003274-RISHABH!
The implementations are correct, but there are few issues that you need to resolve before we can merge this.
- You should not push the executable files in a project, and they usually don't serve any purpose for the other users/contributors. So, you can either add a
.gitignorefile with.exeunder it or simply remove these files. - Same goes for the
.pngfiles. No need to push those. - You should also remove the main function that you have written in the implementations. If you want to verify the changes, you can do that locally in a separate file.
- There also merge conflicts with this PR, you will need to resolve that too.
Let me know, if you need help with anything.
Author
|
I’ll make sure to avoid these in the future by using .gitignore, keeping test code separate, and resolving conflicts before pushing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33 completed