test(undo): give the 500-stroke soak a 30s timeout - #296
Merged
Conversation
The soak does 500 real encode/decode iterations plus ~15 compactions; it runs in ~0.8s locally but is a genuine multi-second job on GitHub runners and flaked past vitest's default 5s per-test timeout on the 0.61.0 release CI (it passed when PR11 part 1 merged - it sits right at the boundary). The test is correct and not hung; raise its ceiling to 30s so runner load can't fail the release. Behaviour unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.61.0 release CI (release PR #295) went red on a flaky timeout, not a real failure:
tests/tile-capture.test.ts→ the 500-stroke eviction/compaction soak exceeded vitest's default 5s per-test timeout on the GitHub runner.The test is correct and not hung — it does 500 real encode/decode iterations plus ~15 compactions (each decoding up to 30 folded entries). It runs in ~0.8s locally and passed when PR11 part 1 merged (#292); it just sits right at the 5s boundary and tips over under runner load.
Fix: raise that one test's ceiling to 30s (
it(..., 30_000)). No behavior or coverage change — still 500 strokes, same assertions.vitest run834/834 locally. Once merged, release-please will refresh #295 and its CI should go green.