feat(undo): enable tile undo by default (PR12) - #294
Merged
Conversation
Flip the nekudot.undoTiles default from "shadow" to "on" after the shadow soak (PR9 shipped 0.57.0; default shadow since, mismatch counters zero across the smoke suite). The tile delta chain now drives undo/redo restore + persistence for everyone. - readUndoTilesMode: unset (and any unknown value) -> "on"; "off" (kill switch) and "shadow" (capture + verify only, the old full-snapshot live path) stay as explicit escape hatches via localStorage. Rollback is a one-line default flip or a per-user localStorage flag; the v1 shadow keyframe keeps even a version rollback lossless. Contained by the boot ladder (a chain hole degrades to "depth lost", never blank paint) and the snapshot fallback (add/remove/reorder-layer steps). Tests: readUndoTilesMode default now "on" + explicit off/shadow/unknown coverage; the two shadow-only AppHistory tests pin the flag. tiled-boot.mjs gains a Phase 0 proving a no-flag user runs on-mode (v2 chain written) - 14/14 on GPU Chrome. Full suite 834. boot-live.mjs unchanged vs main (same 4 pre-existing headless-harness failures, no new ones from the flip).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the default so tile-based undo drives undo/redo restore + persistence for everyone. This is the user-facing cutover the whole roadmap has been building toward (PR1-PR11 all merged).
The change
readUndoTilesMode: unset (and any unknown value) →on."off"(kill switch) and"shadow"(capture + verify only, the old full-snapshot path) remain as explicitlocalStorageescape hatches. One line of real behavior change.Why now / soak basis
shadowsince 0.57.0 (PR9) — three releases of dual-capture + reconstruction-verify.shadow-verify,tiled-boot,tiled-restore,dirty-coverage).console/undoStats, not reported). So "green" means "my coverage is green," not "N users saw zero mismatches." Merging this is the deliberate go/no-go.Safety / rollback
localStorage["nekudot.undoTiles"]="shadow"|"off".Verification
readUndoTilesModenow defaults toonwith explicitoff/shadow/unknown coverage; the two shadow-only AppHistory tests pin the flag.tiled-boot.mjsgains a Phase 0 proving a no-flag user runs on-mode (v2 chain written): 14/14 on GPU Chrome (migration → boot-from-v2 → eviction+undo reload → quota recovery → dpr).tiled-restore.mjs8/8.boot-live.mjs: identical to main — 9/13 with the same 4 pre-existing headless-harness failures (Start-page-on-cold-boot, brush-size-persist, its undo-after-reload flow, reset); the flip adds no new failures.lint/tscclean,build:appOK.Remaining: PR13 (post-rollout cleanup: raise
MAX_UNDO, drop legacy readers) — one release after this.