fix string length validation using char count instead of byte length - #41
Merged
baptiste0928 merged 1 commit intoMay 27, 2026
Conversation
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord validates string option lengtsh using Unicode character count (same as Python's
len()), not byte count. The current impülementation usesvalue.len()which returns the UTF-8 byte length in Rust, causing false validation failures for strings containing multibyte characters (accented letters, CJK characters, emojis, etc.) that are otherwise within Discord's limit.This also replaces the
todo!()stubs with properParseOptionErrorType::StringLengthOutOfRangeerrors.