Skip to content

fix: upgrade multer 1.x to 2.x, replace inMemory with memoryStorage #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dreyesb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: upgrade multer 1.x to 2.x, replace inMemory with memoryStorage #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf94e21
fix: upgrade multer 1.x to 2.x, replace inMemory with memoryStorage
dreyesb Jul 23, 2026
7732324
fix: upgrade lodash 3.x to 4.18.1, fix _.any -> _.some
dreyesb Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions fittings/swagger_params_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ var helpers = require('../lib/helpers');
var bodyParser = require('body-parser');
var async = require('async');
var _ = require('lodash');
var multer = require('multer');

module.exports = function create(fittingDef, bagpipes) {

Expand All @@ -21,7 +22,7 @@ module.exports = function create(fittingDef, bagpipes) {
extended: false
},
multerOptions: {
inMemory: true
storage: multer.memoryStorage()
},
textOptions: {
type: '*/*'
Expand Down Expand Up @@ -84,7 +85,7 @@ function parseRequest(req, fittingDef, cb) {
async.series([
function parseMultipart(cb) {
if (multFields.length === 0) { return cb(); }
var mult = require('multer')(fittingDef.multerOptions);
var mult = multer(fittingDef.multerOptions);
mult.fields(multFields)(req, res, function(err) {
if (err) { /* istanbul ignore next */
if (err.code === 'LIMIT_UNEXPECTED_FILE') { err.statusCode = 400 }
Expand Down
2 changes: 1 addition & 1 deletion fittings/swagger_raw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ module.exports = function create(fittingDef, bagpipes) {

function filterKeysRecursive(object, dropTagRegex, privateTags) {
if (_.isPlainObject(object)) {
if (_.any(privateTags, function(tag) { return object[tag]; })) {
if (_.some(privateTags, function(tag) { return object[tag]; })) {
object = undefined;
} else {
var result = {};
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@
"cors": "^2.5.3",
"debug": "^2.1.3",
"js-yaml": "^3.3.0",
"lodash": "^3.6.0",
"multer": "^1.0.6",
"lodash": "^4.18.1",
"multer": "^2.0.0",
"parseurl": "^1.3.0",
"qs": "^6.4.0",
"sway": "^2.0.0",
Expand Down