Add device family and manufacturer metadata - #479
Merged
Conversation
pranasziaukas
force-pushed
the
device-families-manufacturers
branch
from
May 13, 2026 12:33
d4fb11c to
f26892d
Compare
pranasziaukas
force-pushed
the
device-families-manufacturers
branch
from
July 8, 2026 08:37
f26892d to
fdb9ff3
Compare
pranasziaukas
force-pushed
the
device-families-manufacturers
branch
from
July 20, 2026 14:46
fdb9ff3 to
0ab0aa2
Compare
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
joshbwlng
reviewed
Jul 28, 2026
Contributor
|
And from what I can tell these families are unused, was that intentional?
|
pranasziaukas
force-pushed
the
device-families-manufacturers
branch
2 times, most recently
from
July 28, 2026 08:45
feeb325 to
acfb112
Compare
Contributor
Author
All families should ideally be used. In this case, their references are pending in the https://github.com/balena-io/private-contracts/pull/136 , as their device types are not public.
|
pranasziaukas
force-pushed
the
device-families-manufacturers
branch
from
July 29, 2026 06:05
acfb112 to
acff6e2
Compare
Change-type: patch Signed-off-by: Pranas Ziaukas <pranas@balena.io>
pranasziaukas
force-pushed
the
device-families-manufacturers
branch
from
July 30, 2026 06:40
acff6e2 to
a74ddb0
Compare
thgreasi
reviewed
Aug 3, 2026
thgreasi
marked this pull request as draft
August 3, 2026 09:32
auto-merge was automatically disabled
August 3, 2026 09:32
Pull request was converted to draft
thgreasi
approved these changes
Aug 3, 2026
thgreasi
left a comment
thgreasi
left a comment
Member
There was a problem hiding this comment.
I'm not a fan of the many generics & unknowns that were added, but I'm fine w/ it if you need them.
I would have preferred NULLs in the FKs, instead of unknown/generic, since the unknown/generic families/manufacturers can imply that two device types are related, while in reality we have no clue, and the way to disambiguate them would then be to check for the generic & unknown slugs, instead of just checking for NULLs.
joshbwlng
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add curated device family and manufacturer mappings for existing device types
https://balena.fibery.io/Work/Project/Categorize-device-types-into-families-and-manufacturers-1952