Respect timezone env var - #251
Conversation
Added note about adjusting timezone for Docker container.
fetch upstream changes
|
Need to figure out why tests failing and fix |
|
This test insert a datetime value of mysql_ch_replicator/tests/test_data_types.py Line 235 in 05aa15f But the binlog replicator reads it as Output from binlog reader: Binlogreader adds this offset ir-respective of the timezone value set in So the actual root cause of the problem is binlogreader or the code which reads binlog files and prepares the events for mysql_ch_replicator to insert into clickhouse... Edit: ❯ docker exec -it tests-mysql_db-1 /bin/bash ❯ docker exec -it tests-clickhouse_db-1 /bin/bash ❯ docker exec -it tests-replicator-1 /bin/bash EDIT 2: |
|
Hm, need to think what could be done here, i will take a look, thanks. |
interestingly enough this ain't happening on my production server. The binlog reader isn't adding an extra offset while reading events from bin log files. The conversion happens only at insert time and that too only if the timezone is set to other than local one. Edit: edit 2: which confirms that the problem is with mysql_ch_replicator's bin log reader as its adding an +4h offset |
fix bug #250 which was introduced in #238