Add solarized patch - #162
Conversation
|
I don't think that it makes sense to add individual colour schemes in this project as it would quickly add a lot of clutter in the configuration file. If we were to incorporate individual colour schemes then the configuration would end up being a long list of if else blocks. The current available colour scheme patches are:
but there are hundreds that one could choose from. I get that this is introducing two colour schemes (light and dark) and the possibility to swap between them, but it would still be adding a colour scheme specific patch. I'd say that one can expect users to be able to apply some configuration changes on their own. It would be more flexible to handle this using Xresources, pywal or even theme.sh. |
|
The patch is not simply for the colour schemes, for that I agree that a It is mainly for the code that goes along, to be able to switch between the two, which is the main rationale behind the (widely used) solarized palette. The code changes are simple but annoying for every user to apply, which is the purpose of this PR. I think the aim of this project should be to offer at least the official patches available on the suckless st page. If you are afraid the |
The two colorschemes are available and can be chosen with the XK_ANY_MOD + XK_F6 shortcut (default to dark). The patch seems compatible with the ALPHA* patches, although I could not really test the integration, as the alpha transparency does not seem to work. fix slipped file saving minor fixes sloppy if...
The two colorschemes are available and can be chosen with the XK_ANY_MOD + XK_F6 shortcut (default to dark).
The patch seems compatible with the ALPHA* patches, although I could not really test the integration, as the alpha transparency does not seem to work.