A suggestion on making flexipatch-finalizer less final - #10
Open
Thermatix wants to merge 4 commits into
Open
Conversation
Add `-b, --branch` option so the script can switch to a different branch before processing to allow for script to not be so final
fix small mistake in --branch help
update readme
Owner
|
Based on the proposed changes I take it that the general idea behind this change is to start a new branch named finalized before finalizing the code? The flexipatch-finalizer is more final than that given that it deletes the .git directory so branching beforehand would be moot. Usually you would run the script specifying a different output directory for your finalized build, e.g. something along the lines of: $ ~/path/to/flexipatch-finalizer.sh -d dwm-flexipatch -o dwm-finalizedIn which case the contents of dwm-flexipatch is copied to dwm-finalized before the actual work starts in the latter directory leaving the source directory intact. |
Author
|
I forgot about that, I guess setting I updated the PR to reflect that. |
`--branch` implies `--git`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I don't know if you thought of doing this as a potential method to keep "flexipatch-finalizer" from being so final, but I didn't notice anything like this in the closed issues.
I freely admit I haven't tested this, just wrote this up in GitHub itself whilst trying to keep to the same coding style.
So feel free to "dump on" any mistakes, this is meant as a suggestion or a thought on a possible way to do this (this being, not deleting all the files).