Skip to content

add other absence - #292

Open
SLMitch wants to merge 1 commit into
bain3:masterfrom
SLMitch:add_absence_46
Open

add other absence#292
SLMitch wants to merge 1 commit into
bain3:masterfrom
SLMitch:add_absence_46

Conversation

@SLMitch

@SLMitch SLMitch commented Jan 22, 2024

Copy link
Copy Markdown

Hi,

I notice on my client interface that I have some "absences" not yet classified in current categories (no absence, no punishment).

It is under "Défauts de carnet/carte."

I am adding an "OtherAbsence" class, only with a name, in order to create a "sandbox" for absences. Maybe someone will create other classes with more detail, but my classes can be used to sort "other categories" of absences.

Regards

@tarneaux

tarneaux commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

I don't think this should be the way to do it: I'd prefer having a dataclass that describes absences, with an attribute telling the type (of which an unknown one) and another with the full category name given by Pronote.

Edit: looks like we already have Absence.reasons of type List[str]. I'm not sure what you mean with "classified in current categories". To me absences aren't classified in pronotepy, am I missing something?

@SLMitch
SLMitch force-pushed the add_absence_46 branch 2 times, most recently from 5dc2a28 to ba9e14f Compare January 10, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants