add other absence - #292
Open
SLMitch wants to merge 1 commit into
Open
Conversation
Contributor
|
I don't think this should be the way to do it: I'd prefer having a dataclass that describes absences, with an attribute telling the type (of which an unknown one) and another with the full category name given by Pronote. Edit: looks like we already have |
SLMitch
force-pushed
the
add_absence_46
branch
from
August 15, 2024 12:49
b7b3a09 to
51b4b59
Compare
SLMitch
force-pushed
the
add_absence_46
branch
2 times, most recently
from
January 10, 2025 11:41
5dc2a28 to
ba9e14f
Compare
SLMitch
force-pushed
the
add_absence_46
branch
from
September 2, 2025 19:59
ba9e14f to
a2292b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I notice on my client interface that I have some "absences" not yet classified in current categories (no absence, no punishment).
It is under "Défauts de carnet/carte."
I am adding an "OtherAbsence" class, only with a name, in order to create a "sandbox" for absences. Maybe someone will create other classes with more detail, but my classes can be used to sort "other categories" of absences.
Regards