fix(desktop): draw bookmark markers on the playback timeline (#616) - #618
Open
badbread wants to merge 1 commit into
Open
fix(desktop): draw bookmark markers on the playback timeline (#616)#618badbread wants to merge 1 commit into
badbread wants to merge 1 commit into
Conversation
Bookmarks never appeared on the desktop timeline, regardless of which client created them: the motion-timeline controller fetched intensity + detections only, and the painter had no bookmark glyph. Android and iOS both draw saved bookmarks as gold downward triangles at the top of the band, so a bookmark added on the phone was listed in the desktop Bookmarks screen but invisible on the strip. - controller: fetch the caller's bookmarks alongside the window data, keep the loaded cameras' entries, guarded so a bookmarks failure (toggle off) never blanks the intensity/detections that just loaded - painter: gold marker (Android's TimelineColors.bookmark) with a dark halo at the band top, solo-mode visibility and selected-camera prominence matching the detection glyphs; drawn last so it stays on top - hover: a bookmark chip (note or 'Bookmark', camera, time) wins the hit-test over detections - playback: refresh the timeline right after a successful add so the new marker shows immediately Fixes #616 Signed-off-by: badbread <badbread@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #616.
Bug: a bookmark (e.g. added on Android) shows in the desktop Bookmarks screen but has no indicator on the playback timeline.
Cause: parity gap, not a sync issue. Android (
CenteredTimeline2c) and iOS (CenteredTimelineView2c) draw saved bookmarks as gold downward triangles at the top of the band; the desktop motion timeline fetched intensity + detections only and had no bookmark glyph, so no bookmark ever appeared there, whichever client created it.Fix:
TimelineColors.bookmark) with a dark halo at the band top; solo-mode visibility and selected-camera prominence match the detection glyphs; drawn last so it stays on topVerify:
flutter build windows --debuggreen on winbuild. The marker itself is desktop UI, so the visual check is running the app with a bookmarked camera.