Skip to content

fix #67 #68 - #69

Open
naeemrashid wants to merge 1 commit into
masterfrom
gradle-wrapper
Open

fix #67 #68#69
naeemrashid wants to merge 1 commit into
masterfrom
gradle-wrapper

Conversation

@naeemrashid

@naeemrashid naeemrashid commented Nov 30, 2017

Copy link
Copy Markdown
Contributor

This Branch includes fixes to #67 and #68 👍 .

success

@goxr3plus

goxr3plus commented Dec 6, 2017

Copy link
Copy Markdown
Collaborator

@Naeemkhan12 I will merge this branch if you do the below :)

We need only these files from all the files you have changed:)

1) gradlew.bat
2) build.gradle
3) gradlew

Some depencities are very old for Example Xerial sqlite current version is 3.20.1 , hm i will push some commits these days.

All the others have been correctly done by @badarshahzad . I checked the project structure and it seems very good . Also why use Gradle 2.0 when the latest version is 4.3.1

@goxr3plus

Copy link
Copy Markdown
Collaborator

@badarshahzad Have a look at the depencities . In Maven they were defined like this , i see the Gradle File and they are very old ->

<!-- JAVAFX GRAPHICS LIBRARIES -->
		<dependency>
			<groupId>org.controlsfx</groupId>
			<artifactId>controlsfx</artifactId>
			<version>8.40.14</version>
		</dependency>
		<dependency>
			<groupId>com.jfoenix</groupId>
			<artifactId>jfoenix</artifactId>
			<version>1.9.1</version>
		</dependency>

		<!-- DATABASE DRIVERS -->
		<dependency>
			<groupId>org.xerial</groupId>
			<artifactId>sqlite-jdbc</artifactId>
			<version>3.20.1</version>
		</dependency>

		<!-- ETC LIBRARIES -->
		<dependency>
			<groupId>com.itextpdf</groupId>
			<artifactId>itextpdf</artifactId>
			<version>5.5.12</version>
		</dependency>

		<!-- https://mvnrepository.com/artifact/com.pdfcrowd/pdfcrowd -->
		<dependency>
			<groupId>com.pdfcrowd</groupId>
			<artifactId>pdfcrowd</artifactId>
			<version>4.0.1</version>
		</dependency>


		<!-- https://mvnrepository.com/artifact/org.loadui/testFx -->
		<dependency>
			<groupId>org.loadui</groupId>
			<artifactId>testFx</artifactId>
			<version>3.1.2</version>
			<scope>test</scope>
		</dependency>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants