Skip to content

Fix Android native print intent gesture and QR Studio flaky browser test - #351

Merged
baba-dev merged 4 commits into
mainfrom
fix/android-printer-gesture-qr-stability-20261110
Nov 10, 2026
Merged

baba-dev merged 4 commits into
mainfrom
fix/android-printer-gesture-qr-stability-20261110

Conversation

@baba-dev

Copy link
Copy Markdown
Owner

Scope

Follow-up to merged #350; implement only the three requested audit corrections.

A — Native printer launch (P1)

  • Replace navigation to an Android intent:// URL after an awaited fetch with a two-step flow: prepare the existing short-lived signed receipt grant, then show an actual user-tapped Open printer anchor link.
  • The launch link is built with the existing package-restricted intent helper and per-sale URL, and expiry is rechecked synchronously on click. If expired, prevent navigation and ask the user to prepare again.
  • Keep BLE and Print/PDF fallbacks; no changes to receipt authorization, signing, token format, or printer transports.
  • Extend native-print client tests for successful and malformed/expired grants.

B — Android manifest metadata (P2)

C — QR Studio test flake (P2)

  • Root cause: Playwright getByLabel matched two QR inventory at a glance sections while App Router retained an inactive route tree.
  • Scope to #workspace-main [data-testid="tabletop-press"]:visible; require exactly one visible studio, then query the accessible region by name. Real duplicate visible UI still fails.
  • Preserve all existing QR Studio visual, functional, responsive and print-format assertions.

Verification

  • CI required: lint/typecheck, unit/integration/browser suites, Android build and source contract tests.
  • Manual Play-installed Android print handoff is still needed to confirm Chrome/device behaviour; these changes avoid assuming a browser grants activation after a network await.
  • No DB migrations, entitlement/billing changes, additional permissions, or Play production publication.

Do not merge before all mandatory checks pass.

@baba-dev
baba-dev merged commit 6ac3c7a into main Nov 10, 2026
21 checks passed
@baba-dev
baba-dev deleted the fix/android-printer-gesture-qr-stability-20261110 branch November 10, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant