Repository navigation
Fix Play-installed Android app crashing on launch (missing TWA activity) - #349
Merged
Merged
Conversation
11 of 33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0: First Google Play Internal Testing build crashes at launch — reproduced and fixed
Owner confirmed that Play-installed
com.bababuilds.menuminuteimmediately closes when tapping Open. The temporary(unreviewed)listing title and Android icon are normal first-review placeholders.Exact diagnosis
First emulator run #42804640519 reproduced the failure:
The upstream
LauncherActivityalways callsManageDataLauncherActivity.addSiteSettingsShortcutwhile starting, which requires the activity to be declared in the manifest. Our app had omitted it.Fix
com.google.androidbrowserhelper.trusted.ManageDataLauncherActivityinAndroidManifest.xmlwith a site-management URL; make it non-exported and point the application's manage-space entry at it.adb logcatJava fatal exceptions. It fails when the launcher crashes, preserving logs for review.Release
Tracks #340.