Monolithic build#1
Open
b3lix wants to merge 30 commits into
Open
Conversation
b3lix
force-pushed
the
monolithic_build
branch
2 times, most recently
from
April 5, 2025 23:31
4416b22 to
491b61d
Compare
Most changes consists of: - Fixing IDs - Fixing Label for attribute - Removing labels where accidental - Reattaching ID to the proper element instead of div Also changes cypress to respect the proper id schema. Fixes few selectors in cypress. Signed-off-by: David Hanina <dhanina@redhat.com>
Signed-off-by: Carla Martinez <carlmart@redhat.com>
Some libraries (excluding PatternFly, as it will be handled in another effort) need to be updated to its latest version available if possible. Also, Prettier dependency has been updated and a new rule to manage trailing commas has been adapted to all the files. ``` "trailingComma": "es5" ``` Fixes: freeipa#654 Signed-off-by: Carla Martinez <carlmart@redhat.com>
The linter configuration file needs to be adapted to be used with the new version using the migration guide[1]. This will create a new configuration file based on `.eslintrc` and deprecate the old one. Apart from that, the code will need to be adapted as well due to the new eslint parameters. As the `.eslintignore` is not supported anymore, it needs to be removed from the project. All the aforementioned changes can be tested by executing `npm run lint`. [1] - https://eslint.org/docs/latest/use/configure/migration-guide#migrate-your-config-file Signed-off-by: Carla Martinez <carlmart@redhat.com>
The `@types/react-router` dependency is not needed anymore and it is making the `npm install` and `npm run lint` command to fail abruptly. This needs to be handled by installing and configuring ESLint based on the documentation[1] and removing the existing `package-lock.json` file and `node_modules` folder to do `npm install` again. This way, the errors are now fixed. Apart from that, the `tests/ipalab/_venv` folder needs to be added in the `.prettierignore`. [1] - https://eslint.org/docs/latest/use/getting-started#quick-start Signed-off-by: Carla Martinez <carlmart@redhat.com>
Some code related to undefined values is now highlighted by ESLint as errors that need to be fixed. Signed-off-by: Carla Martinez <carlmart@redhat.com>
Testing library is used to perform the unit tests and it needs to be updated, as well as the unit tests. This is due to the unexpected fix of freeipa#677 Fixes: freeipa#677 Signed-off-by: Carla Martinez <carlmart@redhat.com> Signed-off-by: David Hanina <dhanina@redhat.com>
Ensures the migration tool has been used property. Updates all ignore files. Signed-off-by: David Hanina <dhanina@redhat.com>
Changes the always passing test from an expression to a boolean value. Signed-off-by: David Hanina <dhanina@redhat.com>
The `ubuntu-20.04` version is going to be deprecated soon, so this needs to be changed to another version. Also, the node version should be changed to get the latest features and prevent any possible errors due to using an old one. Signed-off-by: Carla Martinez <carlmart@redhat.com>
Some integration tests are failing. Signed-off-by: Carla Martinez <carlmart@redhat.com>
`package-lock` file was updated after reorganizing some commits. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The `IpaNumberInput.test` is failing due to an incorrect handling of the defined variables. Signed-off-by: Carla Martinez <carlmart@redhat.com>
`Main.tsx` file trailing commas need to be removed as established by prettier configuration. Signed-off-by: Carla Martinez <carlmart@redhat.com>
Makes the tests more stable. Avoids unnecessary branching. Signed-off-by: David Hanina <dhanina@redhat.com>
This test was clearly wrong. Signed-off-by: David Hanina <dhanina@redhat.com>
Signed-off-by: David Hanina <dhanina@redhat.com>
Given the likelihood of the `sudo_rules_settings` test to fail, splitting it into several files/test (based on subsections) will reduce the number of failures and encapsulate better the inner logic. Signed-off-by: Carla Martinez <carlmart@redhat.com>
Signed-off-by: David Hanina <dhanina@redhat.com>
The Certificate identity mapping rules must show a list of the available mapping rules (provided by the `certmaprule_find` and `certmaprule_show` API calls) and show them in the main table. Signed-off-by: Carla Martinez <carlmart@redhat.com>
Some waiting and timeout values have been increased to prevent tests to fail. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Certificate id. mapping global configuration' page must display the data retrieved from the `certmapconfig_show` API command. That data must be able to modify the fields via `certmapconfig_mod` command. Signed-off-by: Carla Martinez <carlmart@redhat.com>
`sudo_rules_settings_run_commands.feature` file has an extra dot (`.`) in its name and must be removed. Tests are failing most likely because it tries to asynchronously access and element that must be created first, so waiting times must be adjusted to ensure the given element has is available. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Certificate mapping match' must validate and perform `certmap_match` operation to show the data of a given user certificate. Signed-off-by: Carla Martinez <carlmart@redhat.com>
There are two recent vulnerabilities[1][2] affecting `react-router` library (versions: `>= 7.2.0` and `<= 7.5.1`) when this is used in framework mode [3]. The modern WebUI uses v6 but not in framework mode, so it can be safely added to whitelist to unblock CI gating. [1] - GHSA-cpj6-fhp6-mr6j [2] - GHSA-f46r-rw29-r322 [3] - https://reactrouter.com/start/framework/installation Signed-off-by: Carla Martinez <carlmart@redhat.com>
The 'Certificate Id. mapping rule' > Settings page must show information related to a given rule. Signed-off-by: Carla Martinez <carlmart@redhat.com>
The kebab options must cover the following functionality: - Enable rule (if disabled) - Disable rule (if enabled) - Delete rule (redirecting to main page). Signed-off-by: Carla Martinez <carlmart@redhat.com>
b3lix
force-pushed
the
monolithic_build
branch
2 times, most recently
from
May 4, 2025 23:52
b0c84bc to
786e968
Compare
Some `console.log` leftovers need to be removed as it might contain unrelevant/ critical data. Signed-off-by: Carla Martinez <carlmart@redhat.com>
b3lix
force-pushed
the
monolithic_build
branch
6 times, most recently
from
May 20, 2025 14:28
93f000a to
74503b1
Compare
desc: Implementation of custom plugin infrastructure, built along with core application bundle. Supports PatternFly and also basic HTML components. Provides multiple examples of plugins based on customer use cases. With various customisations of WebUI. Signed-off-by: Erik Belko <ebelko@redhat.com>
|
This PR has not received any attention in 60 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.