feat: automatic advisory design-review pass (validator + challenger)#21
Merged
Conversation
…ision test, comment precision)
…tive footer, seen-hash ordering, test guards)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an automatic, advisory design-review pass: whenever a design/plan artifact is written or native plan mode exits, the plugin asks Claude to dispatch gemini-validator (VALIDATE_DESIGN) and gemini-challenger (CHALLENGE_DESIGN) over it. Closes the gap where a brainstorming spec written to disk got no automatic validate-and-challenge pass (only native plan mode did, and only the validator).
Implements
docs/superpowers/specs/2026-06-02-design-review-pass-design.md.What changed
PostToolUse(Write|Edit)hook (hooks/design-review.sh): path-matches design artifacts (*-design.md,*-plan.md, files underspecs//plans/,DESIGN.md,PLAN.md; overridable viaCLAUDE_PLUGIN_GEMINI_DESIGN_GLOBS), dedups by file content SHA-256 so cosmetic re-edits do not re-fire, and dispatches both agents as an advisory pass.plan-complete.sh) keeps its existing blocking validator and gains an advisory challenger.pending/<agent>.modemarker;subagent-verdict-handler.shconsumes it.advisorymeans a fail/block verdict surfaces but exits 0;blocking(the default when no marker exists) keeps the pre-existing plan-validator and done-claim gates exiting 2. No regression to existing gates.build_advisory_directiveprimitive so advisory consults omit the "Block until..." footer.CLAUDE_PLUGIN_GEMINI_DISABLE_HOOKS/brainstorm.off. Documented ingemini-consultskill andusing-geminirule.Test Plan
fail(default-blocking when no marker).After merge, tag
v0.6.0to let the release workflow publish it. A fresh Claude Code session is required to load the new hook + agent wiring.