Skip to content

Fix/4xx connection close #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azkrishpy wants to merge 1 commit into from
Closed

Fix/4xx connection close #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions source/s3_client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2627,10 +2627,14 @@ void aws_s3_client_notify_connection_finished(
connection->retry_token = NULL;
}

/* If we weren't successful, and we're here, that means this failure is not eligible for a retry. So finish the
* request, and close our HTTP connection. */
/* If we weren't successful, and we're here, that means this failure is not eligible for a retry.
* Close the HTTP connection only for transport-level failures (no HTTP response was received).
* If we received any HTTP response (response_status > 0), the connection is healthy and should
* be returned to the pool rather than destroyed — a 4xx is an application-level error, not a
* transport error. */
if (finish_code != AWS_S3_CONNECTION_FINISH_CODE_SUCCESS) {
if (connection->http_connection != NULL) {
bool received_response = request->send_data.response_status > 0;
if (!received_response && connection->http_connection != NULL) {
aws_http_connection_close(connection->http_connection);
}
}
Expand Down
Loading