Add retroactive inventory and bank appearance backfill#227
Merged
Conversation
Add one-time retroactive backfill for already-owned appearances. - Introduce CheckRetroActiveInventoryAppearances(Player*). - Scan equipped slots, backpack, bag contents, bank main slots, and bank bag contents. - Reuse AddToDatabase() eligibility rules for each found item. - Call inventory backfill from CheckRetroActiveQuestAppearances(). - Add UseCollectionSystem guards to retroactive checks. Result: existing eligible items in inventory/bank are learned on login during retroactive pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously we've had
CheckRetroActiveQuestAppearances()method to retroactively collect appearances that were rewarded from completed quests. This PR addsCheckRetroActiveInventoryAppearances()method that runs during the retroactive pass (whenCheckRetroActiveQuestAppearances()is ran) and collects appearances from items players already own in their inventory or bank.What it does
During the one-time retroactive login pass, it now scans:
Why
Previously, retroactive handling focused on quest rewards and could miss items already sitting in inventory/bank.
Notes