Skip to content

fix(DB/SmartAI): 'Delicate Sound of Thunder' speed buff timing race - #27132

Open
sogladev wants to merge 1 commit into
azerothcore:masterfrom
sogladev:fix/howling-fjord-f1-construct-1
Open

fix(DB/SmartAI): 'Delicate Sound of Thunder' speed buff timing race#27132
sogladev wants to merge 1 commit into
azerothcore:masterfrom
sogladev:fix/howling-fjord-f1-construct-1

Conversation

@sogladev

@sogladev sogladev commented Aug 13, 2026

Copy link
Copy Markdown
Member

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

AI-assisted Pull Requests

Important

Using AI tools to prepare pull requests is allowed, but it must be disclosed and it must follow our AC guidelines for AI Agentic Engineering (link below).

You are expected to fully understand the changes you submit and to be able to explain and justify them when maintainers ask.

  • AI tools (e.g. Claude, ChatGPT, or similar) were used entirely or partially to prepare this pull request. If checked, specify which tools and models below.
    • Tools/models used: DeepSeek V4 Pro + AzerothMCP + Keira3
  • I have read and understood the AC guidelines for AI Agentic Engineering

Issues Addressed:

A rare race can occur when using the jump pad

a mechanical creature there, then if you use the pad, use ability wrongly, then it will give you an insane speedboost that you can use to fly/travel around the map, however, you still are controlling an mechanoid, so nothing really that you can do with that I think.

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

Note: tough to reproduce

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • "falling" animation during WP
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.


Self-review — 21570-howling-fjord-rocket-jump (Part 2) → master

Outcome No findings — clean

Reviewed rev_1786648635519.sql (uncommitted working-tree file, new file — 26 lines, DB/SmartAI only)

By GitHub Copilot, DeepSeek V4 Pro — self-review v0.4, 2026-08-13

Review details (1 round)

Intent Quest 11495 ("The Delicate Sound of Thunder") Part 2: make the Iron Rune Construct's (24825) Rocket Jump speed buff (spell 44626) atomic with the flight — applied by the same SmartAI chain that starts the escort path, removed when the escort stops or the passenger leaves — instead of riding the launch spell for its full 60 s.

Project rules .agents/docs/self-review-rules.md present and applied (with .agents/docs/code-review.md, sql-guidelines.md, cpp-scripts.md)

Round 1 — rev_1786648635519.sql (working tree), clean

No findings.

Notes (not findings):

  1. rev_1786649573107.sql (Part 1) is a separate pending revision that UPDATEs action_param1 to 3 (fly) on the same SMART_ACTION_ESCORT_START rows this file inserts with action_param1 2. It documents being applied on top of Part 2; timestamp order (…5519 < …3107) makes that true. Layering is correct, not a duplicate or conflict.
  2. Whether the construct's synchronous self-cast of 44626 inside its own 44608 spellhit is ever rejected in-game is not determinable from source alone; author confirmed in-game that the buff no longer persists after an interrupted jump.

Copilot AI lite review requested due to automatic review settings August 13, 2026 20:07
@github-actions github-actions Bot added the DB related to the SQL database label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d2052d4-b5b3-4525-a4c1-fe41130cf387

📥 Commits

Reviewing files that changed from the base of the PR and between 2a16f07 and c953baa.

📒 Files selected for processing (1)
  • data/sql/updates/pending_db_world/rev_1786648635519.sql

📝 Walkthrough

Walkthrough

Adds a pending world-database update for the Iron Rune Construct encounter in Howling Fjord. The update removes the linked relationship between spells 44608 and 44626. It replaces creature 24825 smart scripts to manage reputation auras, staged Rocket Jump casts, flight paths, dialogue, and Rocket Jump aura cleanup.

Mergeability Score: ⚪ Minimal · up to c953b

This localized database change has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates world DB SmartAI data for quest 11495 (“The Delicate Sound of Thunder”) to prevent the Iron Rune Construct’s Rocket Jump speed aura (44626) from persisting incorrectly by managing the aura via SmartAI instead of a spell link.

Changes:

  • Removes the spell_linked_spell relationship that auto-applied 44626 from the Rocket Jump launch spell (44608).
  • Rewrites the smart_scripts block for creature 24825 to self-cast 44626 in the same action chain that starts the movement path, and to remove it when the path ends / escort stops / passenger is removed.
Suppressed comments (1)

data/sql/updates/pending_db_world/rev_1786648635519.sql:26

  • The file ends with an extra blank line after the final statement; apps/codestyle/codestyle-sql.py flags any blank line at EOF as a failure ("Multiple blank lines found at the end"). Remove the trailing empty line so the last line is the final INSERT row ending with ';'.
(24825, 0, 18, 0, 28, 0, 100, 512, 0, 0, 0, 0, 0, 0, 28, 44626, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - On Passenger Removed - Remove Aura Rocket Jump');


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +18 to +22
(24825, 0, 11, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24826, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Level 1'),
(24825, 0, 12, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24827, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Level 2'),
(24825, 0, 13, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24828, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Ground Level'),
(24825, 0, 14, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24831, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Level 1 Return'),
(24825, 0, 15, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24829, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Ground Level Return'),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DB related to the SQL database Ready to be Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Howling Fjord] The Delicate Sound of Thunder -- Rocket Jump turns you into an F1 construct

2 participants