fix(DB/SmartAI): 'Delicate Sound of Thunder' speed buff timing race - #27132
fix(DB/SmartAI): 'Delicate Sound of Thunder' speed buff timing race#27132sogladev wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a pending world-database update for the Iron Rune Construct encounter in Howling Fjord. The update removes the linked relationship between spells Mergeability Score: ⚪ Minimal · up to This localized database change has no actionable merge-blocking risk remaining and is merge-ready after normal checks and review. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates world DB SmartAI data for quest 11495 (“The Delicate Sound of Thunder”) to prevent the Iron Rune Construct’s Rocket Jump speed aura (44626) from persisting incorrectly by managing the aura via SmartAI instead of a spell link.
Changes:
- Removes the
spell_linked_spellrelationship that auto-applied 44626 from the Rocket Jump launch spell (44608). - Rewrites the
smart_scriptsblock for creature 24825 to self-cast 44626 in the same action chain that starts the movement path, and to remove it when the path ends / escort stops / passenger is removed.
Suppressed comments (1)
data/sql/updates/pending_db_world/rev_1786648635519.sql:26
- The file ends with an extra blank line after the final statement; apps/codestyle/codestyle-sql.py flags any blank line at EOF as a failure ("Multiple blank lines found at the end"). Remove the trailing empty line so the last line is the final INSERT row ending with ';'.
(24825, 0, 18, 0, 28, 0, 100, 512, 0, 0, 0, 0, 0, 0, 28, 44626, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - On Passenger Removed - Remove Aura Rocket Jump');
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| (24825, 0, 11, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24826, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Level 1'), | ||
| (24825, 0, 12, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24827, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Level 2'), | ||
| (24825, 0, 13, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24828, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Ground Level'), | ||
| (24825, 0, 14, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24831, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Level 1 Return'), | ||
| (24825, 0, 15, 0, 61, 0, 100, 512, 0, 0, 0, 0, 0, 0, 53, 2, 24829, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 'Iron Rune Construct - Rocket Jump - Start flight path Ground Level Return'), |
Changes Proposed:
This PR proposes changes to:
AI-assisted Pull Requests
Important
Using AI tools to prepare pull requests is allowed, but it must be disclosed and it must follow our AC guidelines for AI Agentic Engineering (link below).
You are expected to fully understand the changes you submit and to be able to explain and justify them when maintainers ask.
Issues Addressed:
A rare race can occur when using the jump pad
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
Note: tough to reproduce
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.
Self-review — 21570-howling-fjord-rocket-jump (Part 2) → master
Outcome No findings — clean
Reviewed
rev_1786648635519.sql(uncommitted working-tree file, new file — 26 lines, DB/SmartAI only)By GitHub Copilot, DeepSeek V4 Pro — self-review v0.4, 2026-08-13
Review details (1 round)
Intent Quest 11495 ("The Delicate Sound of Thunder") Part 2: make the Iron Rune Construct's (24825) Rocket Jump speed buff (spell 44626) atomic with the flight — applied by the same SmartAI chain that starts the escort path, removed when the escort stops or the passenger leaves — instead of riding the launch spell for its full 60 s.
Project rules
.agents/docs/self-review-rules.mdpresent and applied (with.agents/docs/code-review.md,sql-guidelines.md,cpp-scripts.md)Round 1 —
rev_1786648635519.sql(working tree), cleanNo findings.
Notes (not findings):
rev_1786649573107.sql(Part 1) is a separate pending revision thatUPDATEsaction_param1to 3 (fly) on the sameSMART_ACTION_ESCORT_STARTrows this file inserts withaction_param12. It documents being applied on top of Part 2; timestamp order (…5519 < …3107) makes that true. Layering is correct, not a duplicate or conflict.