Repository navigation
refactor(Core/EventMap): Refactor EventMap and related scripts - #23121
Conversation
This reverts commit 338694ff7add5b16ffe6e299571c8958c339603d.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes timing in AzerothCore scripts by replacing millisecond integer values with C++14 chrono literals for better type safety and readability. The changes convert timing parameters from raw integers (like 1000, 5000ms) to chrono literals (like 1s, 5s) throughout event scheduling, timing functions, and other time-related operations.
Key changes:
- Converts event scheduling calls from millisecond integers to chrono literals
- Updates function signatures to use
Millisecondstype instead ofuint32 - Replaces timing constants with
constexprchrono duration variables - Modernizes time comparison operations to use chrono-based methods
Reviewed Changes
Copilot reviewed 168 out of 168 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Multiple script files | Converts timing values from raw integers to chrono literals (1s, 5s, etc.) |
| Event scheduling | Updates ScheduleEvent, Repeat, and similar calls to use chrono types |
| Function signatures | Changes timing parameters from uint32 to Milliseconds |
| Time constants | Replaces enum/define constants with constexpr chrono variables |
Comments suppressed due to low confidence (6)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Done |
blinkysc
left a comment
There was a problem hiding this comment.
Cool, not sure why CI not compiling. Works for me?
Co-Authored-By: Kelno <3866946+kelno@users.noreply.github.com> Co-Authored-By: Peter Keresztes Schmidt <carbenium@outlook.com>
|
Nothing has changed, it's just to add the original author. |
|
[ ✔ ] Tested in-game by the author. |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 168 out of 168 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (4)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@Nyeriah |
Merged, thanks! 👍 |
Thank you |
…thcore#23121) Co-authored-by: Kelno <3866946+kelno@users.noreply.github.com> Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>
Changes Proposed:
TrinityCore/TrinityCore@ce1e2c0
TrinityCore/TrinityCore@6ab9922
TrinityCore/TrinityCore@b9795e4
TrinityCore/TrinityCore@8cb35b0
TrinityCore/TrinityCore@4470b91
TrinityCore/TrinityCore@7865c1c
TrinityCore/TrinityCore@1bea4aa
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.