Skip to content

refactor(Core/EventMap): Refactor EventMap and related scripts - #23121

Merged
Nyeriah merged 19 commits into
azerothcore:masterfrom
PkllonG:EventMap
Oct 13, 2025
Merged

Nyeriah merged 19 commits into
azerothcore:masterfrom
PkllonG:EventMap

Conversation

@PkllonG

@PkllonG PkllonG commented Oct 5, 2025 •

Copy link
Copy Markdown
Contributor

Changes Proposed:

TrinityCore/TrinityCore@ce1e2c0
TrinityCore/TrinityCore@6ab9922
TrinityCore/TrinityCore@b9795e4
TrinityCore/TrinityCore@8cb35b0
TrinityCore/TrinityCore@4470b91
TrinityCore/TrinityCore@7865c1c
TrinityCore/TrinityCore@1bea4aa

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • [ ✔ ] Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

This reverts commit 338694ff7add5b16ffe6e299571c8958c339603d.
@github-actions github-actions Bot added CORE Related to the core Script Refers to C++ Scripts for the Core file-cpp Used to trigger the matrix build labels Oct 5, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes timing in AzerothCore scripts by replacing millisecond integer values with C++14 chrono literals for better type safety and readability. The changes convert timing parameters from raw integers (like 1000, 5000ms) to chrono literals (like 1s, 5s) throughout event scheduling, timing functions, and other time-related operations.

Key changes:

  • Converts event scheduling calls from millisecond integers to chrono literals
  • Updates function signatures to use Milliseconds type instead of uint32
  • Replaces timing constants with constexpr chrono duration variables
  • Modernizes time comparison operations to use chrono-based methods

Reviewed Changes

Copilot reviewed 168 out of 168 changed files in this pull request and generated no comments.

File Description
Multiple script files Converts timing values from raw integers to chrono literals (1s, 5s, etc.)
Event scheduling Updates ScheduleEvent, Repeat, and similar calls to use chrono types
Function signatures Changes timing parameters from uint32 to Milliseconds
Time constants Replaces enum/define constants with constexpr chrono variables
Comments suppressed due to low confidence (6)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@PkllonG PkllonG changed the title EventMap refactor(Core/EventMap): Oct 5, 2025
@PkllonG PkllonG changed the title refactor(Core/EventMap): refactor(Core/EventMap): Refactor EventMap and related scripts Oct 5, 2025
@PkllonG

PkllonG commented Oct 5, 2025

Copy link
Copy Markdown
Contributor Author

Done

@blinkysc blinkysc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, not sure why CI not compiling. Works for me?

PkllonG and others added 3 commits October 8, 2025 23:08
Co-Authored-By: Kelno <3866946+kelno@users.noreply.github.com>
Co-Authored-By: Peter Keresztes Schmidt <carbenium@outlook.com>
EventMap

Co-Authored-By: Kelno <3866946+kelno@users.noreply.github.com>
Co-Authored-By: Peter Keresztes Schmidt <carbenium@outlook.com>
@PkllonG

PkllonG commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

Nothing has changed, it's just to add the original author.

@PkllonG

PkllonG commented Oct 9, 2025 •

Copy link
Copy Markdown
Contributor Author

[ ✔ ] Tested in-game by the author.

@sudlud
sudlud requested a review from Copilot October 11, 2025 06:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 168 out of 168 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (4)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Nyeriah
Nyeriah merged commit 9c49349 into azerothcore:master Oct 13, 2025
15 of 17 checks passed
@PkllonG
PkllonG deleted the EventMap branch October 13, 2025 01:24
@PkllonG PkllonG mentioned this pull request Oct 13, 2025
11 tasks
@PkllonG

PkllonG commented Oct 13, 2025 •

Copy link
Copy Markdown
Contributor Author

@Nyeriah
They may also need to be merged.
azerothcore/mod-morphsummon#26
azerothcore/mod-npc-beastmaster#73

@Helias

Helias commented Oct 13, 2025

Copy link
Copy Markdown
Member

@Nyeriah They may also need to be merged. azerothcore/mod-morphsummon#26 azerothcore/mod-npc-beastmaster#73

Merged, thanks! 👍

@PkllonG

PkllonG commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

@Nyeriah They may also need to be merged. azerothcore/mod-morphsummon#26 azerothcore/mod-npc-beastmaster#73

Merged, thanks! 👍

Thank you

Tereneckla pushed a commit to Tereneckla/azerothcore-wotlk that referenced this pull request Oct 20, 2025
…thcore#23121)

Co-authored-by: Kelno <3866946+kelno@users.noreply.github.com>
Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE Related to the core file-cpp Used to trigger the matrix build Ready to be Reviewed Script Refers to C++ Scripts for the Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants