Skip to content

feat: support phpmyadmin port configuration#51

Merged
Helias merged 1 commit into
azerothcore:masterfrom
assumptionsandg:feat/support-phpmyadmin-port
Jun 29, 2026
Merged

feat: support phpmyadmin port configuration#51
Helias merged 1 commit into
azerothcore:masterfrom
assumptionsandg:feat/support-phpmyadmin-port

Conversation

@assumptionsandg

@assumptionsandg assumptionsandg commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Support port configure of phpmyadmin. I've been carrying a local patch for this: https://github.com/assumptionsandg/ansible-collection-azerothcore/blob/main/roles/azerothcore_install/defaults/main.yml#L59-L61

Haven't tested with env yet... will rebase my scripts on this when I get a chance to test.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The phpmyadmin service port mapping in docker-compose.yml is changed from a hardcoded 8080:80 to ${DOCKER_PHPMYADMIN_PORT:-8080}:80, making the host port configurable via environment variable with 8080 as the default.

Changes

phpMyAdmin Port Configuration

Layer / File(s) Summary
Configurable phpmyadmin port
docker-compose.yml
Port mapping replaced with ${DOCKER_PHPMYADMIN_PORT:-8080}:80 to allow host port override via environment variable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hopped by and said, "Oh my!
Port eight-oh-eight-oh was fixed to the sky.
Now set it yourself with a variable key,
Default still holds — it's 8080, you see!"
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: making phpMyAdmin port configuration configurable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Helias Helias merged commit dab87ea into azerothcore:master Jun 29, 2026
2 of 3 checks passed
@Helias

Helias commented Jun 29, 2026

Copy link
Copy Markdown
Member

thanks for the PR!

@assumptionsandg assumptionsandg deleted the feat/support-phpmyadmin-port branch June 29, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants