Skip to content
This repository was archived by the owner on Jul 6, 2024. It is now read-only.

Added Pre OTA Update Callback - #76

Open
anindyamitra15 wants to merge 6 commits into
ayushsharma82:masterfrom
anindyamitra15:master
Open

Added Pre OTA Update Callback#76
anindyamitra15 wants to merge 6 commits into
ayushsharma82:masterfrom
anindyamitra15:master

Conversation

@anindyamitra15

@anindyamitra15 anindyamitra15 commented Nov 9, 2021

Copy link
Copy Markdown

If someone needs to run some code just before the update begins, it can be done by adding the line: AsyncElegantOTA.preFotaRoutineCallback(callback); to the setup. All the instructions are written under Documentation in
README
Tested this with ESP8266 as well as ESP32, works on both.

@ayushsharma82

Copy link
Copy Markdown
Owner

Hi @anindyamitra15 ,
Thanks a lot for this addition.

Can you rename it to onOTAStart ?

If possible, please replicate the same for ElegantOTA library as well. These 2 libraries go hand in hand in regards to functionality.

@anindyamitra15

Copy link
Copy Markdown
Author

Hi @anindyamitra15 , Thanks a lot for this addition.

Can you rename it to onOTAStart ?

If possible, please replicate the same for ElegantOTA library as well. These 2 libraries go hand in hand in regards to functionality.

Ok I will rename it to onOTAStart
And then I'll also implement it on the non-async version as well

@anindyamitra15

Copy link
Copy Markdown
Author

All requested change(s) for this repository has been made. Kindly let me know if there are more changes to be done.
I'll proceed with ElegantOTA soon.

@anindyamitra15

Copy link
Copy Markdown
Author

@ayushsharma82

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants