This repository was archived by the owner on Jul 6, 2024. It is now read-only.
Added optional OTA start, progress and end callback - #109
Open
PeterAckermans wants to merge 5 commits into
Open
Conversation
Added code for optional pre OTA call back. Will add documentation later
PreUpdateCallback was call prior to the check for errors
|
Hello ayushsharma82, |
|
hello, could you add this feature , accept request ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As I needed a callback on start of OTA to save the status of my program to resume after the date I added optional interfaces to get a callback
Prior to OTA start
On OTA progress
After OTA completed
The implementation is backward compatible to your latest release.
It doesn't require any changes to existing user that don't need any of the callback functions
The callback is only activated once you call the activation call with the correct callback function added.
PS: I also update the standard OTA library with exactly the same class extensions.
As I only have an ESP32 I couldn't test on ESP8266 but as I only added no architecture dependent code it should work out of the box.