This repository was archived by the owner on Jul 6, 2024. It is now read-only.
Fix ESP32-S2 restart - #108
Open
joelsernamoreno wants to merge 1 commit into
Open
Conversation
flowerysong
reviewed
Sep 20, 2022
Comment on lines
+114
to
+126
| #if defined CONFIG_IDF_TARGET_ESP32S2 || defined CONFIG_IDF_TARGET_ESP32S2 | ||
| yield(); | ||
| delay(1000); | ||
| yield(); | ||
| esp_task_wdt_init(1,true); | ||
| esp_task_wdt_add(NULL); | ||
| while(true); | ||
| #else | ||
| yield(); | ||
| delay(1000); | ||
| yield(); | ||
| ESP.restart(); | ||
| #endif |
There was a problem hiding this comment.
Since the basic example works this seems likely to be a bug elsewhere in your code/the code you rely on, rather than something that this library should deal with.
If this workaround is actually necessary, you should structure the code so it's clear what is actually different between the branches:
Suggested change
| #if defined CONFIG_IDF_TARGET_ESP32S2 || defined CONFIG_IDF_TARGET_ESP32S2 | |
| yield(); | |
| delay(1000); | |
| yield(); | |
| esp_task_wdt_init(1,true); | |
| esp_task_wdt_add(NULL); | |
| while(true); | |
| #else | |
| yield(); | |
| delay(1000); | |
| yield(); | |
| ESP.restart(); | |
| #endif | |
| yield(); | |
| delay(1000); | |
| yield(); | |
| #if defined(CONFIG_IDF_TARGET_ESP32S2) | |
| // Normal restarts don't work due to X. Abuse the watchdog timer to perform a hard reset. | |
| esp_task_wdt_init(1, true); | |
| esp_task_wdt_add(NULL); | |
| while(true); | |
| #else | |
| ESP.restart(); | |
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I have been using ESP32-S2 with the AsyncElegantOTA library and other libraries (for example esptinyusb).
I have identified that when updating the firmware with AsyncElegantOTA, ESP32-S2 goes into download mode on reboot (This only happens if I use other libraries, if I use the basic AsyncElegantOTA example this does not happen). Attached is an image:
ESP32-S2 does not reboot properly and does not run the new firmware. You have to physically disconnect and reconnect the ESP32S2 from the computer.
To fix this I have modified AsyncElegantOtaClass::restart in AsyncElegantOta.cpp to force ESP32-S2 to properly restart and run the new firmware after the restart. Maybe there is another cleaner solution, but my modification causes ESP32-S2 to be restarted without entering download mode:
Thanks!