Skip to content
This repository was archived by the owner on Jul 6, 2024. It is now read-only.

Fix ESP32-S2 restart - #108

Open
joelsernamoreno wants to merge 1 commit into
ayushsharma82:masterfrom
joelsernamoreno:master
Open

Fix ESP32-S2 restart#108
joelsernamoreno wants to merge 1 commit into
ayushsharma82:masterfrom
joelsernamoreno:master

Conversation

@joelsernamoreno

Copy link
Copy Markdown

Hello!

I have been using ESP32-S2 with the AsyncElegantOTA library and other libraries (for example esptinyusb).

I have identified that when updating the firmware with AsyncElegantOTA, ESP32-S2 goes into download mode on reboot (This only happens if I use other libraries, if I use the basic AsyncElegantOTA example this does not happen). Attached is an image:

Selección_072

ESP32-S2 does not reboot properly and does not run the new firmware. You have to physically disconnect and reconnect the ESP32S2 from the computer.

To fix this I have modified AsyncElegantOtaClass::restart in AsyncElegantOta.cpp to force ESP32-S2 to properly restart and run the new firmware after the restart. Maybe there is another cleaner solution, but my modification causes ESP32-S2 to be restarted without entering download mode:

Selección_073

Thanks!

Comment thread src/AsyncElegantOTA.cpp
Comment on lines +114 to +126
#if defined CONFIG_IDF_TARGET_ESP32S2 || defined CONFIG_IDF_TARGET_ESP32S2
yield();
delay(1000);
yield();
esp_task_wdt_init(1,true);
esp_task_wdt_add(NULL);
while(true);
#else
yield();
delay(1000);
yield();
ESP.restart();
#endif

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the basic example works this seems likely to be a bug elsewhere in your code/the code you rely on, rather than something that this library should deal with.

If this workaround is actually necessary, you should structure the code so it's clear what is actually different between the branches:

Suggested change
#if defined CONFIG_IDF_TARGET_ESP32S2 || defined CONFIG_IDF_TARGET_ESP32S2
yield();
delay(1000);
yield();
esp_task_wdt_init(1,true);
esp_task_wdt_add(NULL);
while(true);
#else
yield();
delay(1000);
yield();
ESP.restart();
#endif
yield();
delay(1000);
yield();
#if defined(CONFIG_IDF_TARGET_ESP32S2)
// Normal restarts don't work due to X. Abuse the watchdog timer to perform a hard reset.
esp_task_wdt_init(1, true);
esp_task_wdt_add(NULL);
while(true);
#else
ESP.restart();
#endif

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants