Update security_policy.rb to fix casing issue breaking idempotency - #132
Open
mit-da wants to merge 1 commit into
Open
Update security_policy.rb to fix casing issue breaking idempotency#132mit-da wants to merge 1 commit into
mit-da wants to merge 1 commit into
Conversation
It seems having having the incorrect casing for `LanManServer` in the `Microsoft network server: Server SPN target name validation level` policy is causing this policy to apply repeatedly even though it is set correctly. Specifically the name is currently `'MACHINE\System\CurrentControlSet\Services\LanmanServer\Parameters\SmbServerNameHardeningLevel'` when it should be `'MACHINE\System\CurrentControlSet\Services\LanManServer\Parameters\SmbServerNameHardeningLevel'` like the rest of the values. Verified this in our setup where before, it would show up during each puppet run, even though a quick pass at the registry value and secpol.msc showed it was set correctly. After this case change it now longer shows up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems having having the incorrect casing for
LanManServerin theMicrosoft network server: Server SPN target name validation levelpolicy is causing this policy to apply repeatedly even though it is set correctly. Specifically the name is currently'MACHINE\System\CurrentControlSet\Services\LanmanServer\Parameters\SmbServerNameHardeningLevel'when it should be'MACHINE\System\CurrentControlSet\Services\LanManServer\Parameters\SmbServerNameHardeningLevel'like the rest of the values.Verified this in our setup where before, it would show up during each puppet run, even though a quick pass at the registry value and secpol.msc showed it was set correctly. After this case change it now longer shows up.