Skip to content

Open external links in new tab; Add drop down link to referenced section on FAQ page - #27

Open
hamberguesa wants to merge 3 commits into
aymannadeem:masterfrom
hamberguesa:links
Open

Open external links in new tab; Add drop down link to referenced section on FAQ page#27
hamberguesa wants to merge 3 commits into
aymannadeem:masterfrom
hamberguesa:links

Conversation

@hamberguesa

Copy link
Copy Markdown
Contributor

It's best practice, both for SEO reasons and UX, to have external links open in a new tab. (We don't want users to lose your valuable website when clicking through to a resource.)

I also added a drop down link to the referenced "Afgan and Iraqi SIVs" section on the FAQ page for ease of navigation.

@dmleong

dmleong commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

There is some accessibility things that should be kept in consideration if we allow links to open into a new tab since it breaks the default behavior of links. Older screen readers have a difficult time opening new tabs, although new ones will tell you when a new tab opens. http://libux.co/links-should-open-in-the-same-window/

I would argue that we should allow users to decide if they would like links to open in new tabs, rather than making the decision for them.

@puriifynews

Copy link
Copy Markdown

tks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants