feat: remote AI dispatch + Settings + secure storage + release pipeline - #4
Open
aymandakirgh wants to merge 14 commits into
Open
feat: remote AI dispatch + Settings + secure storage + release pipeline#4aymandakirgh wants to merge 14 commits into
aymandakirgh wants to merge 14 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything fixable in code toward production. Stacks on the MVP PR (#3) — review/merge that first.
The differentiator: remote AI dispatch
The command bar now actually does what the README promises. Unrecognized queries (anything the local handlers don't resolve) dispatch to a user-configured AI backend.
AIDispatching+OpenAICompatibleDispatcher— POSTs to any OpenAI-compatible/chat/completions(OpenAI, Ollama local, proxies). InjectableURLSession; typed errors.submit()with a loading spinner.Settings (⌘,)
SettingsView— base URL, model, API key, OpenAI/Ollama presets, Save.SettingsStore— endpoint config →UserDefaults; API key → Keychain (KeychainSecretStore).SecretStoringprotocol keeps the Keychain out of CI (tests useInMemorySecretStore).Settingsscene (wasEmptyView).UX fix
The panel no longer collapses out from under you while typing — hover-leave only collapses when the command bar is idle (
shouldStayOpen).Production infra
.github/workflows/release.yml— on av*tag: build → (sign + notarize if secrets present) → DMG → GitHub Release. Gated: produces an unsigned DMG today, a signed+notarized one once the Apple cert secrets exist.RELEASING.md— exact secrets + steps, and the standing blocker spelled out.Tests (+15 assertions)
AIDispatcherTests(stub URLProtocol: success/HTTP-error/empty/unconfigured),AISettingsTests(URL building, config, persistence round-trip),CommandBarViewModelTests(local resolve, remote dispatch, unconfigured hint, stay-open). CI runs them on this PR.Still NOT production — unchanged blockers
Not in scope: media controls, calendar, file shelf, system HUD; streaming AI responses; conversation history.
🤖 Generated with Claude Code