Skip to content

Legacy select format card support - #1387

Open
crait wants to merge 5 commits into
masterfrom
legacy-select-format-card-support
Open

Legacy select format card support#1387
crait wants to merge 5 commits into
masterfrom
legacy-select-format-card-support

Conversation

@crait

@crait crait commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@crait
crait requested a review from axpendix as a code owner June 23, 2026 17:29
Comment on lines +1833 to +1834
case DARK_PATCH_139:
return copy(DarkExplorers.DARK_PATCH_93, this)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new implementations this is now specified in cards/yaml files in "variantOf" field instead of the implementation files. Once that's specified then during the implementation discovery phase, it automatically receives the implementation of the variant. Then these lines should be deleted. Sorry, it's an undocumented new part of the engine.

Comment on lines +1833 to +1834
case DARK_PATCH_139:
return copy(DarkExplorers.DARK_PATCH_93, this)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new implementations this is now specified in cards/yaml files in "variantOf" field instead of the implementation files. Once that's specified then during the implementation discovery phase, it automatically receives the implementation of the variant. Then these lines should be deleted. Sorry, it's an undocumented new part of the engine.

Comment on lines +1898 to +1917
case HISUIAN_HEAVY_BALL_146:
return itemCard (this) {
text "Look at your face-down Prize cards. You may reveal a Basic Pokémon you find there, put it into your hand, and put this Hisuian Heavy Ball in its place as a face-down Prize card. (If you don't reveal a Basic Pokémon, put this card in the discard pile.) Then, shuffle your face-down Prize cards.\nYou may play any number of Item cards during your turn."
onPlay {
my.prizeCardSet.showToMe("Your prizes")
if(my.prizeCardSet.has(BASIC)){
def tar = my.prizeCardSet.filterByType(BASIC).select(min:0,"Replace $thisCard with one of your prizes?")
if(tar){
tar.showToOpponent("Your opponent put this card in his hand")
my.hand.remove(thisCard)
my.prizeCardSet.set(my.prizeCardSet.indexOf(tar.first()), thisCard)
my.hand.add(tar.first())
bc "Took $tar and shuffled $thisCard into prizes"
}
my.prizeCardSet.shuffle()
}
}
playRequirement{
}
};

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need go one step above, meaning that we are now using cardng structure instead with no metadata.

Comment on lines +1971 to +1988
case SUPEREFFECTIVE_GLASSES_152:
return pokemonTool (this) {
text "When applying Weakness to damage from the attacks of the Pokémon this card is attached to done to your opponent's Active Pokémon, apply it as ×3.\nYou may play any number of Item cards during your turn.\nAttach a Pokémon Tool to 1 of your Pokémon that doesn't already have a Pokémon Tool attached."
def eff
onPlay {reason->
effect = delayed {
before APPLY_WEAKNESS, {
bg.dm().each{
if(it.from==self && it.to.active){
it.flags.add(DamageManager.DamageFlag.FORCE_X3_WEAKNESS)
}
}
}
}
onRemoveFromPlay {
effect.unregister()
}
};

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before the structure must match cardng

HAWLUCHA_127,
DRAMPA_V_128,
ACEROLA_S_PREMONITION_129,
ACEROLA_S_PREMONITION_129 ("Acerola's Premonition", "129", Rarity.UNCOMMON, [SUPPORTER, TRAINER]),

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata is now split to YAML files so this line should be reverted

Comment on lines +1855 to +1856
case COLLAPSED_STADIUM_137:
return copy(GymHeroes.NARROW_GYM_124, this)

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be specified as a variant as well since it has the same text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants