feat(server): add support for multiple CA certs#2
Conversation
a6f2e62 to
89773a8
Compare
89773a8 to
1abfa22
Compare
There was a problem hiding this comment.
Let's try to contribute this back to upstream.
There are 2 questions I would be interested in, but those are not blockers in any way:
-
I have memories that it is possible to create a cert trust chain, and the Windows clients sent the entire chain except for the root CA. In that case, thumbprint check may have to be done on the last cert's issuer, not on the first.
-
Listing multiple thumbprints in the enumerate response worked as far as I remember. We discussed that it is no longer the case (or I remember incorrectly), so you populated a hashtable instead. Using the issuer field as key should be good enough?!
Maybe we could check the exact generated SOUP payload to verify if this list idea works or not.
|
I'd suggest opening an upstream PR, allowing the maintainers/authors to comment on it. |
cb89e9b to
3ba0587
Compare
This is done in preparation for supporting multiple CAs Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
This is done in preparation for supporting multiple CAs Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
… subject Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
1abfa22 to
e7fbefe
Compare
No description provided.