Changed .vsixmanifest to support Visual Studio 2019.#191
Conversation
|
|
|
Yeah if someone can solve this before April when VS2019 goes live I know it'd help my team. We are all about the OpenCover and we all like what this extension brings to Visual Studio! |
|
Gave you tested this with the released 2019? It complains about missing CoreEditor for me |
|
Even with this manifest, it does not seem to identify VS 2019. Something more is needed for this extension to work. I have tried to do some investigation, but can't seem to find out what is preventing the extension to identify VS 2019 as a valid installation target. |
|
VsixUpdater(https://github.com/axodox/VsixUpdater) works to override these tags when make .vsix file. |
|
r-matsunaga you are right :-) I also managed to make it install on VS 2019 after removing the VsixUpdater. It looks like that module is overriding what is entered in the manifest file, and forcing the module to not identify VS 2019 as a valid target. Thank you very much for the tip. |
|
Is there a released VSIX somewhere? I can't build AxoCover locally :/ |
|
I have uploaded my compiled vsix to dropbox: https://www.dropbox.com/s/1s8oodc4rm3f8fc/AxoCover.vsix?dl=0 It seems to be working fine. Only issue is the yellow bar on the top upon startup, saying that it will not be compatible with future versions of VS. |
kjetilroe
left a comment
kjetilroe
left a comment
There was a problem hiding this comment.
VsixUpdater also need to be removed before it will run on VS 2019.
aelking
left a comment
aelking
left a comment
There was a problem hiding this comment.
Is this going to be approved anytime soon, VS2019 has been out for a while, and this is something that is really missing.
|
I will look into this over the weekend |
|
I have created VSIX updater to maintain VS2012 compatibility (still used at my company by some people pn legacy projects) and to decrease VSIX size. I have updated the VS version there. Nuget is still doing validation, so I will have to wait some time to rebuild AxoCover. |
|
Sorry the new build is not good yet. |
|
I checked again it seems that the original reason for VSIX updater - that it was not possible to build packages which are compatible from VS2012 to VS2017 is not a problem anymore, but I would still keep it for its compression ability. I have updated it, and the VSIX manifest, so now new builds should work on VS2019. For the async loading further work is required. |
|
Please check this build on VS 2019 and 2012 (and between :D): https://github.com/axodox/AxoCover/releases/tag/master-1.1.400 |
|
The build works fine on VS 2019, I even don't get the yellow warning about deprecated plugin stuff that came up with the other vsix :-) |
|
I will wait a bit for more confirmations, and possible error reports. Until that you may use the above build. If everything is fine I will push this out to VS marketplace in a few weeks. |
|
Hi @axodox , Tested the previously mentionned build on VS 19 (Version 16.1.16) and it works fine, except warning from VS saying : "Visual Studio did not load one or more extensions that were using deprecated APIs" since I added the extension ... Great work none the less, really appreciated ! |
|
master-1.1.400 works fine on my
|
|
Hi all, whats the latest with this PR? |
|
Bump |
|
Can it be done again for VS2022 ? |
14 participants
I really love this extension, so I am trying to contribute with #188 , following this article: https://blogs.msdn.microsoft.com/visualstudio/2018/09/26/how-to-upgrade-extensions-to-support-visual-studio-2019/
As said there, only changing the .vsixmanifest may work things out. I couldn't test the extension locally because I failed to setup the environment to debug, so if someone could run it prior to accepting, would be greatly appreciated!
Sorry if I did something wrong in regards of the pull request, I'm unexperienced with GitHub.