Skip to content

feat(v2.1): use standard zkvm accelerator interface for openvm intrinsics - #694

Merged
shuklaayush merged 44 commits into
develop-v2.1.0from
feat/c-interface
Aug 12, 2026
Merged

feat(v2.1): use standard zkvm accelerator interface for openvm intrinsics#694
shuklaayush merged 44 commits into
develop-v2.1.0from
feat/c-interface

Conversation

@shuklaayush

@shuklaayush shuklaayush commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Combines the standard zkVM accelerator work from the earlier stacked PRs.

  • Implements the standard, client-independent zkVM accelerator C interface for OpenVM crypto operations.
  • Routes the REVM and Alloy crypto providers through that interface, removing the duplicate provider implementations.
  • Simplifies the crate layout to one module and integration test per accelerator, while retaining only the shared BN254/BLS support modules.
  • Fixes C output-pointer handling and preserves the EIP-2537 subgroup rules.

Validated with the full accelerator/provider test suite, clippy, and OpenVM RISC-V guest builds.

Reth benchmark: develop-v2.1.0 vs feat/c-interface on block 24846099

Supersedes the earlier stacked PRs:

Closes #686
Closes #687
Closes #689
Closes #690
Closes #691
Closes #692
Closes #693

Resolves INT-8880
Resolves INT-8932
Resolves INT-8933
Resolves INT-8934
Resolves INT-8935
Resolves INT-8939
Resolves INT-8940

@shuklaayush shuklaayush changed the title feat(v2.1): use standard zk accelerator interface for openvm intrinsics feat(v2.1): use standard zkvm accelerator interface for openvm intrinsics Aug 12, 2026
Comment thread crates/accelerators/tests/bn254.rs Outdated

@mansur20478 mansur20478 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no obvious issues

@Qumeric Qumeric left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at accelerators themselves, assuming they are correct

revm-crypto LGTM

My LLMs have found no issues

@shuklaayush
shuklaayush merged commit de91506 into develop-v2.1.0 Aug 12, 2026
12 checks passed
@shuklaayush
shuklaayush deleted the feat/c-interface branch August 12, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants