perf(mpt): align witness nodes for keccak - #669
Closed
Qumeric wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #668.
Aligns serialized witness nodes to the XORIN instruction’s 8-byte boundary so decode-side hashes can absorb aligned full blocks without staging copies. The empty-trie and unresolved-digest paths derive padding from the same format rule.
Benchmark result
Block 24001988 with a freshly generated witness, comparing #668 with this PR:
execute_metered_insnsmetered_rows_unpaddedmetered_main_cells_unpaddedmetered_interaction_cells_unpaddedmetered_memory_unpadded_bytesThe instruction saving does not compensate for the larger witness’s main-cell, memory, and segment regressions, so this change is not being kept.