perf: cache repeated storage trie lookups - #665
Closed
Qumeric wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by #683 — same change, reparented onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #664.
Add one-entry caches for address hashes and storage-trie references in
WitnessDb. REVM storage accesses commonly arrive in runs for the same account, so this avoids repeated address Keccak operations and storage-trie hash-table lookups without adding a general-purpose cache.WitnessDbborrows the backing Ethereum state immutably, so cached trie references cannot become stale during execution.Benchmark results
Block 24001988, RVR execution. The attribution points 29811230163 and 29750974205 differ only by this cache change:
execute_metered_insnsmetered_rows_unpaddedmetered_main_cells_unpaddedmetered_interaction_cells_unpaddedBlock 24003902
RVR execution: #664, this PR.
execute_metered_insnsmetered_rows_unpaddedmetered_main_cells_unpaddedmetered_interaction_cells_unpaddedmetered_memory_unpadded_bytes