[feat] shared base MSM many - #27
Draft
jonathanpwang wants to merge 2 commits into
Draft
Conversation
Mamy's suggestion
Collaborator
Author
|
edit: tried keccak_bits and on my laptop (Arm, better memory) it is worse than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An untested hypothesis is that when the number of columns is high, the current version of doing
best_multiexpone column at a time is not optimal because it is not memory local and doesn't use the fact that the base of the MSM is always the same (namely the KZG params).This is a quick edit so that for a batch of columns, when we
commit_lagrangewe do all MSM for a chunk of thebasesin a single thread.Haven't tested it on any wide circuits to compare.