Add ScalarField for secp256r1 - #338
Open
nbarbier-265 wants to merge 2 commits into
Open
Conversation
Implements ScalarField for P-256 field types to enable use with halo2-ecc. Follows same pattern as secp256k1 and bn254.
nbarbier-265
force-pushed
the
add-p256-scalar-field
branch
2 times, most recently
from
November 15, 2025 04:32
49f4db5 to
beeeb26
Compare
…version Expanded the macro-based ScalarField implementations for secp256r1Fp and secp256r1Fq to manually handle big-endian to little-endian conversion, ensuring correct byte ordering for these field types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
nbarbier-265
force-pushed
the
add-p256-scalar-field
branch
from
November 15, 2025 04:33
beeeb26 to
c53c5dc
Compare
stephenh-axiom-xyz
force-pushed
the
main
branch
from
August 10, 2026 14:25
eef4038 to
4d3bcea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337
Adds ScalarField implementations for secp256r1 (P-256) field types.
Enables P-256 ECDSA verification in halo2-ecc circuits. Matches existing implementations for secp256k1 and bn254.