Skip to content

Fix halo2-wasm template struct name - #62

Open
0xisk wants to merge 3 commits into
axiom-crypto:mainfrom
0xisk:main
Open

Fix halo2-wasm template struct name#62
0xisk wants to merge 3 commits into
axiom-crypto:mainfrom
0xisk:main

Conversation

@0xisk

@0xisk 0xisk commented Mar 25, 2024

Copy link
Copy Markdown

This PR adds a little fix for the template to return the MyCircuit circuit rather than Halo2WasmTemplate which I think that was the initial intention.

@vercel

vercel Bot commented Mar 25, 2024

Copy link
Copy Markdown

@0xisk is attempting to deploy a commit to the Axiom Crypto Team on Vercel.

A member of the Team first needs to authorize it.

@yi-sun
yi-sun requested a review from rpalakkal March 25, 2024 06:01
@vercel

vercel Bot commented Mar 25, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
halo2-repl ❌ Failed (Inspect) Mar 25, 2024 6:01am

@0xisk

0xisk commented Mar 25, 2024

Copy link
Copy Markdown
Author

Also I think renaming this param circuit to halo2Wasm or halo2_wasm makes more sense, since the type is not a circuit its the Halo2Wasm lib.

pub fn new(circuit: &Halo2Wasm) -> Self {

@rpalakkal rpalakkal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Could you also change rename the circuit param to halo2_wasm?

@0xisk
0xisk requested a review from rpalakkal March 27, 2024 06:20
@0xisk

0xisk commented Mar 27, 2024

Copy link
Copy Markdown
Author

Thank you for this! Could you also change rename the circuit param to halo2_wasm?

Thank you! I also renamed other variables here: 0f5b1fc

  • Halo2LibWasm -> halo2_lib_wasm
  • Halo2Wasm -> halo2_wasm

Do you agree with that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants