Created a linebreaks_iter() variant of linebreaks - #11
Open
nwoods-cimpress wants to merge 1 commit into
Open
Conversation
…lexibility
`linebreaks` has a very simple interface - it takes a `&str` and returns an iterator returning break opportunities tagged by positions. This change introduces a `linebreaks_iter()` variant that instead of taking a `&str`:
- Takes an iterator passing in `char` and arbitary indexes that do not necessarily have to be `usize`
- A `final_idx` parameter containing the final index.
The original `linebreaks()` function can now easily be implemented in terms of `linebreaks_iter()`:
````
pub fn linebreaks(s: &str) -> impl Iterator<Item = (usize, BreakOpportunity)> + Clone + '_ {
linebreaks_iter(s.char_indices(), s.len())
}
````
This allows the core algorithm to be decoupled from the representation of the string, allowing text to be passed in alternative formats (e.g. - UTF-16 or UTF-8) or possibily a complex data structure where everything is not conveniently a singular string.
Author
|
I think that it is unfortunate that the If there is a way in Rust to support implementing |
Author
|
@axelf4 any thoughts on this PR? |
|
I came here to make exactly this change. My use-case is similar to those mentioned in #1 and this PR would be great for my needs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linebreakshas a very simple interface - it takes a&strand returns an iterator returning break opportunities tagged by positions. This change introduces alinebreaks_iter()variant that instead of taking a&str:charand arbitrary indexes that do not necessarily have to beusizefinal_idxparameter containing the final index.The original
linebreaks()function can now easily be implemented in terms oflinebreaks_iter():This allows the core algorithm to be decoupled from the representation of the string, allowing text to be passed in alternative formats (e.g. - UTF-16 or UTF-8) or possibly a complex data structure where everything is not conveniently a singular string.