engines/io_uring: add copyright header to bsg files - #2125
Merged
Conversation
Add the copyright header to bsg.c and bsg.h, which provide BSG (Block SCSI Generic) support for the io_uring_cmd engine. The files were previously committed without a license header. Signed-off-by: Jungwon Lee <jjung1.lee@samsung.com>
Collaborator
|
It is a shame to litter files with copyright headers (when the code wasn't taken from another project and copied verbatim) and I think these days projects like the Linux kernel they actively try to avoid doing this. I understand companies want to protect their work but as fio wasn't started/isn't run entirely by Samsung perhaps some exception can be made? @vincentkfu , @axboe what are your thoughts? |
Collaborator
|
Our lawyers have requested that we include these copyright headers. I view these headers as an acknowledgement of the support that these enterprises provide to maintain and improve Fio, so I am inclined to allow them. |
Owner
|
FWIW, I don't think there's anything wrong with adding copyright headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the copyright header to bsg.c and bsg.h, which provide BSG (Block SCSI Generic) support for the io_uring_cmd engine. The files were previously committed without a license header.