Skip to content

ci: welcome only a person's first issue or pull request - #8

Merged
awss1i merged 1 commit into
mainfrom
welcome-first-time
Oct 18, 2026
Merged

awss1i merged 1 commit into
mainfrom
welcome-first-time

Conversation

@awss1i

@awss1i awss1i commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

What This Changes

The welcome bot comments "Thanks for your first pull request here" on pull requests from people who have opened one before, including the owner. actions/first-interaction causes this, in v3.1.0 and on its main branch (actions/first-interaction#369). It comments when either of two checks passes, and both are wrong for a pull request:

  • It checks whether the author has opened an issue before, so anyone who has never opened an issue gets the pull request welcome every time.
  • Its pull request check counts earlier pull requests by anyone, not by the author.

This replaces the action with a gh step. The step lists the author's earlier issues and pull requests from the REST issues endpoint, keeps the ones of the same kind with a lower number, and comments only when there are none. The owner and bots are skipped. The welcome messages are unchanged.

GitHub runs pull_request_target workflows from the base branch, so this pull request gets the old comment one more time.

Kind

  • Bug fix
  • False-alarm fix
  • Benchmark improvement
  • Feature
  • Plugin or harness support
  • Docs
  • Misc

Tests

I ran the step's script locally against this repository with the comment call replaced by echo:

author number kind result
awss1i 7 pull request no welcome, has #6
awss1i 8 issue welcome (the job's if skips the owner first)
dependabot[bot] 5 pull request no welcome, has #4 (the job's if skips bots first)
a new author 9 pull request welcome

With a repository that doesn't exist, gh api fails and the step exits 1 without posting.

Benchmarks

Not needed. The change doesn't touch a rule or any file in bench/.

AI use

  • AI-written or AI-assisted, and I've read every line.

@awss1i
awss1i merged commit 815736a into main Oct 18, 2026
8 checks passed
@awss1i awss1i added the misc Changes outside assay itself, like CI or .gitattributes label Oct 18, 2026
@awss1i
awss1i deleted the welcome-first-time branch October 18, 2026 23:56
Repository owner deleted a comment from github-actions Bot Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

misc Changes outside assay itself, like CI or .gitattributes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant