Skip to content

Feat/universal aggregate update#4

Closed
hayleypark wants to merge 15 commits into
devfrom
feat/universal_aggregate_update
Closed

Feat/universal aggregate update#4
hayleypark wants to merge 15 commits into
devfrom
feat/universal_aggregate_update

Conversation

@hayleypark

@hayleypark hayleypark commented Oct 10, 2025

Copy link
Copy Markdown

Issue #, if available:

Description of changes:

  • Deprecate aggregate = True flag in src/stickler/structured_object_evaluator/models/comparable_field.py, src/stickler/structured_object_evaluator/models/comparison_info.py and src/stickler/structured_object_evaluator/models/configuration_helper.py (not currently used in calculation)
  • Update exiting test cases for correct universal aggregate metrics calculation without changing the overall metrics related test cases
  • Add a new test cases for universal aggregate metrics calculation (tests/structured_object_evaluator/test_ecommerce_orders_aggregate_comprehensive.py)
  • Update the evaluator and the bulk evaluator to optionally use aggregate metrics
  • Assumption: For aggregate metrics, all matched items (regardless of the similarity score) are considered. For overall metrics, only those above match threshold are considered.
  • TODO: Implementation of the aggregation logic in src/stickler/structured_object_evaluator/models/structured_model.py and src/stickler/structured_object_evaluator/models/structured_list_comparator.py to pass these tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sromoam
sromoam self-requested a review October 13, 2025 20:30
@hayleypark
hayleypark marked this pull request as ready for review October 27, 2025 20:31
@hayleypark

Copy link
Copy Markdown
Author

Created #72 instead

@hayleypark hayleypark closed this Jan 30, 2026
@adiadd
adiadd deleted the feat/universal_aggregate_update branch July 21, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant