Add aws_array_list_shuffle for Fisher-Yates in-place shuffle - #1249
Closed
erikfuller wants to merge 1 commit into
Closed
Add aws_array_list_shuffle for Fisher-Yates in-place shuffle#1249erikfuller wants to merge 1 commit into
erikfuller wants to merge 1 commit into
Conversation
Add a general-purpose in-place shuffle function for aws_array_list using the Fisher-Yates algorithm with aws_device_random for randomness. Returns AWS_OP_SUCCESS on success, or propagates an error if the random source is unavailable. No-op for lists with 0 or 1 elements.
erikfuller
force-pushed
the
feat/array-list-shuffle
branch
from
June 1, 2026 23:53
0766eab to
a5f9a89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
aws_array_list_shuffle()— a general-purpose Fisher-Yates in-place shuffle foraws_array_list, usingaws_device_randomfor randomness.Motivation
Needed by aws-c-s3 (PR #636) to implement randomized byte-range fetch ordering for multipart downloads. Rather than inlining the shuffle logic, it belongs here as a reusable utility alongside
aws_array_list_sortandaws_array_list_swap.API
AWS_OP_SUCCESSon successTesting
test_array_list_shuffle— verifies valid permutation (all elements present, non-sequential)test_array_list_shuffle_empty— verifies edge cases (empty list, single element)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.