Skip to content

Add Build Option to Control CPU Extension Usage (MinGW/Clang) #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eranif wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Build Option to Control CPU Extension Usage (MinGW/Clang) #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,14 @@ aws_set_common_properties(${PROJECT_NAME} NO_WEXTRA)
aws_prepare_symbol_visibility_args(${PROJECT_NAME} "AWS_COMMON")
target_compile_options(${PROJECT_NAME} PUBLIC ${PLATFORM_CFLAGS})

if (NOT USE_CPU_EXTENSIONS)
target_compile_definitions(${PROJECT_NAME} PUBLIC -DHAS_CPU_EXTENSTIONS=0)
message(STATUS "Adding -DHAS_CPU_EXTENSTIONS=0 to target ${PROJECT_NAME}")
else ()
target_compile_definitions(${PROJECT_NAME} PUBLIC -DHAS_CPU_EXTENSTIONS=1)
message(STATUS "Adding -DHAS_CPU_EXTENSTIONS=1 to target ${PROJECT_NAME}")
endif ()

# Check public headers, to ensure they're safe for any 3rdparty to include
set(HEADERS_TO_CHECK ${AWS_COMMON_HEADERS})

Expand Down
2 changes: 1 addition & 1 deletion source/encoding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#include <ctype.h>
#include <stdlib.h>

#ifdef USE_SIMD_ENCODING
#if defined(USE_SIMD_ENCODING) && HAS_CPU_EXTENSTIONS
size_t aws_common_private_base64_decode_sse41(const unsigned char *in, unsigned char *out, size_t len);
void aws_common_private_base64_encode_sse41(
const unsigned char *in,
Expand Down