CBMC: Add proof for aws_string_new_from_buf - #1232
Open
GeorgiaGriffin wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a CBMC proof harness for the aws_string_new_from_buf function, which previously lacked formal verification. The proof verifies that the function correctly creates a valid string from a byte buffer.
Key changes:
- Adds proof harness with preconditions ensuring valid allocator and byte buffer
- Verifies postconditions: correct length, null termination, matching bytes, and string validity
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
verification/cbmc/proofs/aws_string_new_from_buf/cbmc-proof.txt |
Marker file indicating the directory contains a CBMC proof |
verification/cbmc/proofs/aws_string_new_from_buf/aws_string_new_from_buf_harness.c |
Proof harness that verifies aws_string_new_from_buf returns a valid string with correct properties |
verification/cbmc/proofs/aws_string_new_from_buf/Makefile |
Build configuration for the CBMC proof, including necessary source files and dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, and/or reason for changes (REQUIRED):
aws_string_new_from_buf did not have a proof for CBMC verification.
Description of changes:
Create a proof harness for aws_string_new_from_buf. The proof verifies that the function returns a valid string given preconditions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.