fix(dsql): reframe JSON/JSONB/array storage as a choice, not "MUST use JSONB"#200
Open
amaksimo wants to merge 2 commits into
Open
fix(dsql): reframe JSON/JSONB/array storage as a choice, not "MUST use JSONB"#200amaksimo wants to merge 2 commits into
amaksimo wants to merge 2 commits into
Conversation
amaksimo
requested review from
a team,
krokoko,
scottschreckengaust and
theagenticguy
amaksimo
requested review from
Benjscho,
Morlej,
gxjx-x,
jaichabria,
pkale,
praba2210 and
spencercorwin
…e JSONB"
The native JSON/JSONB rollout left this skill prescribing a single answer.
Two drift directions existed: some files said "MUST serialize arrays as
JSONB" / "prefer JSONB over JSON" (over-correction), others still said
"store as TEXT" / "SET -> TEXT" (stale pre-JSON framing).
Bring all nine steering files in line with the already-reviewed wording in
awslabs/mcp: serializing is the MUST (DSQL has no array column type); the
format is a choice — PREFER JSONB for queryable values, MAY use TEXT when
opaque, JSON when writes dominate or byte-exact preservation matters; keep
existing JSON columns as JSON when migrating. ASK the user.
Files: SKILL.md, references/development-guide.md, references/onboarding.md,
references/troubleshooting.md, references/examples/{patterns,schema}.md,
references/mysql-migrations/{type-mapping,full-example,ddl-type-alternatives}.md.
Bump databases-on-aws to 1.3.3.
amaksimo
force-pushed
the
fix/dsql-jsonb-reframe-drift
branch
from
1d0562d to
099bba1
Compare
anwesham-lab
approved these changes
Jun 18, 2026
anwesham-lab
left a comment
anwesham-lab
left a comment
Member
There was a problem hiding this comment.
All previously cycled and reviewed including in the MCP standalone skill vending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The native JSON/JSONB rollout left this skill prescribing a single answer for array/document storage. Two drift directions existed across the nine steering files:
The reviewed wording already in
awslabs/mcpreframes this as a choice. This PR brings thedatabases-on-awsDSQL skill in line.The reframe
JSONBwhen querying inside the value (@>,?,jsonb_array_elements_text, indexed paths); values normalized at write.TEXTwhen the column is opaque to the database (app parses the whole value, never queries inside).JSONwhen writes dominate, byte-exact input matters (audit, replay, duplicate keys), or only->/->>is needed.JSONcolumns asJSONwhen migrating; upgrade toJSONBonly if JSONB-only operators/indexed paths are needed.Files
SKILL.md,references/development-guide.md,references/onboarding.md,references/troubleshooting.md,references/examples/{patterns,schema}.md,references/mysql-migrations/{type-mapping,full-example,ddl-type-alternatives}.md. Bumpsdatabases-on-awsto 1.3.3.Validation
quick_validate.pypasses.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.