Conversation
Collaborator
Author
|
performance numbers when running this patch against our service/internal/serdebenchmark in the SDK 
|
Madrigal
approved these changes
Aug 6, 2026
Madrigal
left a comment
Madrigal
left a comment
Contributor
There was a problem hiding this comment.
Minor comments, super happy to see this!
| req.URL.Path = "/" | ||
| } | ||
| req.Header.Set("X-Amz-Target", fmt.Sprintf("%s.%s", p.serviceName, middleware.GetOperationName(ctx))) | ||
| req.Header.Set("X-Amz-Target", fmt.Sprintf("%s.%s", p.serviceName, schema.ID().Name)) |
Contributor
There was a problem hiding this comment.
is this available even on non-migrated services?
Collaborator
Author
There was a problem hiding this comment.
as in non-schema serde services? they're not calling this
| return &ShapeDeserializer{p: p, head: serde.NewStack[deserCtx](), opts: o} | ||
|
|
||
| d := &ShapeDeserializer{p: p, head: serde.NewStack[deserCtx](), opts: o} | ||
| d.arena.Reset(len(p) / 4) |
Collaborator
Author
There was a problem hiding this comment.
a fourth of the payload up to 4k, i'll const this
| } | ||
| } | ||
|
|
||
| // An indefinite-length byte string is legal CBOR that ReadBlob does not |
| } | ||
| } | ||
|
|
||
| func BenchmarkHasBlobPayload(b *testing.B) { |
Contributor
There was a problem hiding this comment.
do we run testing.B tests?
Collaborator
Author
There was a problem hiding this comment.
this was mostly intermediate to check the schema extension perf improved it, i'm probably jst gonna delete this
| presize = maxPresize | ||
| } | ||
|
|
||
| // + bytes.MinRead prevents pointless doubling on EOF |
Co-authored-by: Luis Madrigal <599908+Madrigal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@httpPayload + blobrather than io.ReadAll