Skip to content

fix schema-serde sparse collection deser to not point to the same value #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucix-aws merged 1 commit into from
Jul 31, 2026
+6 −2
Merged

fix schema-serde sparse collection deser to not point to the same value #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...y-go-codegen/src/main/java/software/amazon/smithy/go/codegen/serde2/ListDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ private void renderDense(GoWriter writer) {
private void renderSparse(GoWriter writer) {
writer.writeGoTemplate("""
func deserialize$shapeName:L(d smithy.ShapeDeserializer, s *smithy.Schema, v *$symbol:T) error {
var vv $memberSymbol:T
return smithy.ReadList(d, s, func() error {
if isNil, err := d.ReadNil(s.ListMember()); err != nil {
return err
Expand All @@ -78,6 +77,9 @@ private void renderSparse(GoWriter writer) {
return nil
}

// vv must be declared per-element for sparse since we
// are taking its pointer
var vv $memberSymbol:T
$zeroValue:W
if err := $deserializeMember:W; err != nil {
return err
Expand Down
4 changes: 3 additions & 1 deletion ...hy-go-codegen/src/main/java/software/amazon/smithy/go/codegen/serde2/MapDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ private void renderSparse(GoWriter writer) {
writer.writeGoTemplate("""
func deserialize$shapeName:L(d smithy.ShapeDeserializer, s *smithy.Schema, v *$symbol:T) error {
*v = make($symbol:T)
var vv $valueSymbol:T
return smithy.ReadMap(d, s, func(k string) error {
if isNil, err := d.ReadNil(s.MapValue()); err != nil {
return err
Expand All @@ -80,6 +79,9 @@ private void renderSparse(GoWriter writer) {
return nil
}

// vv must be declared per-element for sparse since we
// are taking its pointer
var vv $valueSymbol:T
$zeroValue:W
if err := $deserializeValue:W; err != nil {
return err
Expand Down
Loading