Skip to content

handle null cbor struct val #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucix-aws merged 1 commit into from
Jul 30, 2026
+3 −4
Merged

handle null cbor struct val #689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...src/main/java/software/amazon/smithy/go/codegen/serde/cbor/CborDeserializerGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,10 +317,9 @@ private Writable deserializeField(MemberShape member) {
return emptyGoTemplate(); // event stream, not an actual field
}

var memberSymbol = symbolProvider.toSymbol(member);
return goTemplate("""
if key == $field:S {
$nilable:W
$skipNull:W
dv, err := $deserialize:L(sv)
if err != nil {
return nil, err
Expand All @@ -333,11 +332,11 @@ private Writable deserializeField(MemberShape member) {
"fieldName", symbolProvider.toMemberName(member),
"deserialize", getDeserializerName(normalize(target)),
"deref", generateStructFieldDeref(member, "dv"),
"nilable", isNilable(memberSymbol) ? handleSparseField() : emptyGoTemplate()
"skipNull", handleNullField()

@Madrigal Madrigal Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so smithycbor.Nil doesn't pass isNilable(memberSymbol) because it's an actual value that represents a nil value?

));
}

private Writable handleSparseField() {
private Writable handleNullField() {
return goTemplate("""
if _, ok := sv.($P); ok {
continue
Expand Down
Loading